add createMethod #2

Merged
lqhoang99 merged 4 commits from feature/createMethod into master 2021-11-05 09:28:06 +00:00
3 changed files with 24 additions and 27 deletions
Showing only changes of commit 85c9692da0 - Show all commits

View File

@ -61,16 +61,16 @@ func (s Service) Create(payload CreateOptions) error {
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
func (payload CreateOptions) newDevice() (result Device, err error) {
timeNow := now()
device := Device{
ID: mongodb.NewObjectID(),
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
DeviceID: payload.DeviceID,
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
OSName: getOSName(payload.UserAgent),
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
OSVersion: getOSVersion(payload.UserAgent),
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
IP: payload.IP,
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
Language: getLanguage(payload.Language),
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
AuthToken: payload.AuthToken,
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
LastActivityAt: timeNow,
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
CreatedAt: timeNow,
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
FCMToken: payload.FCMToken,
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
ID: mongodb.NewObjectID(),
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
DeviceID: payload.DeviceID,
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
OSName: getOSName(payload.UserAgent),
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
OSVersion: getOSVersion(payload.UserAgent),
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
IP: payload.IP,
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
Language: getLanguage(payload.Language),
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
AuthToken: payload.AuthToken,
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
LastActivatedAt: timeNow,
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
CreatedAt: timeNow,
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
FCMToken: payload.FCMToken,
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
}
// App version

namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:27:44 +00:00 (Migrated from github.com)
Review

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:31:39 +00:00 (Migrated from github.com)
Review

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:33:20 +00:00 (Migrated from github.com)
Review
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:14 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:31 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:35:53 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:36:56 +00:00 (Migrated from github.com)
Review

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:25 +00:00 (Migrated from github.com)
Review

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
namhq1989 commented 2021-11-05 07:37:32 +00:00 (Migrated from github.com)
Review

bỏ cái này

bỏ cái này
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:32:48 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:21 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:28 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:33:54 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:00 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:13 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:23 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 08:34:30 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
namhq1989 commented 2021-11-05 08:58:38 +00:00 (Migrated from github.com)
Review

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 09:12:15 +00:00 (Migrated from github.com)
Review

done

done

View File

@ -26,12 +26,9 @@ func (s Service) isDeviceIDExisted(ctx context.Context, deviceID string) bool {
namhq1989 commented 2021-11-05 09:17:08 +00:00 (Migrated from github.com)
Review

gom code khúc này thành return !device.ID.IsZero()

func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false

gom code khúc này thành `return !device.ID.IsZero()` func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false
namhq1989 commented 2021-11-05 09:17:08 +00:00 (Migrated from github.com)
Review

gom code khúc này thành return !device.ID.IsZero()

func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false

gom code khúc này thành `return !device.ID.IsZero()` func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false
lqhoang99 commented 2021-11-05 09:25:11 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 09:25:11 +00:00 (Migrated from github.com)
Review

done

done
"deviceID": deviceID,
"err": err.Error(),
})
namhq1989 commented 2021-11-05 09:15:34 +00:00 (Migrated from github.com)
Review

chỗ này return luôn chớ?

chỗ này return luôn chớ?
lqhoang99 commented 2021-11-05 09:25:18 +00:00 (Migrated from github.com)
Review

done

done
}
namhq1989 commented 2021-11-05 09:17:08 +00:00 (Migrated from github.com)
Review

gom code khúc này thành return !device.ID.IsZero()

func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false

gom code khúc này thành `return !device.ID.IsZero()` func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false
lqhoang99 commented 2021-11-05 09:25:11 +00:00 (Migrated from github.com)
Review

done

done
if !device.ID.IsZero() {
namhq1989 commented 2021-11-05 09:17:08 +00:00 (Migrated from github.com)
Review

gom code khúc này thành return !device.ID.IsZero()

func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false

gom code khúc này thành `return !device.ID.IsZero()` func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false
lqhoang99 commented 2021-11-05 09:25:11 +00:00 (Migrated from github.com)
Review

done

done
return true
}
namhq1989 commented 2021-11-05 09:17:08 +00:00 (Migrated from github.com)
Review

gom code khúc này thành return !device.ID.IsZero()

func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false

gom code khúc này thành `return !device.ID.IsZero()` func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false
lqhoang99 commented 2021-11-05 09:25:11 +00:00 (Migrated from github.com)
Review

done

done
return false
namhq1989 commented 2021-11-05 09:17:08 +00:00 (Migrated from github.com)
Review

gom code khúc này thành return !device.ID.IsZero()

func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false

gom code khúc này thành `return !device.ID.IsZero()` func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false
lqhoang99 commented 2021-11-05 09:25:11 +00:00 (Migrated from github.com)
Review

done

done
return !device.ID.IsZero()
namhq1989 commented 2021-11-05 09:17:08 +00:00 (Migrated from github.com)
Review

gom code khúc này thành return !device.ID.IsZero()

func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false

gom code khúc này thành `return !device.ID.IsZero()` func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false
lqhoang99 commented 2021-11-05 09:25:11 +00:00 (Migrated from github.com)
Review

done

done
}
func getOSName(userAgent string) string {

namhq1989 commented 2021-11-05 09:17:08 +00:00 (Migrated from github.com)
Review

gom code khúc này thành return !device.ID.IsZero()

func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false

gom code khúc này thành `return !device.ID.IsZero()` func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false
namhq1989 commented 2021-11-05 09:17:08 +00:00 (Migrated from github.com)
Review

gom code khúc này thành return !device.ID.IsZero()

func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false

gom code khúc này thành `return !device.ID.IsZero()` func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false
lqhoang99 commented 2021-11-05 09:25:11 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 09:25:11 +00:00 (Migrated from github.com)
Review

done

done

View File

@ -8,17 +8,17 @@ import (
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
// Device ...
type Device struct {
namhq1989 commented 2021-11-05 07:41:01 +00:00 (Migrated from github.com)
Review

define thêm json vào metadata

define thêm `json` vào metadata
lqhoang99 commented 2021-11-05 08:40:21 +00:00 (Migrated from github.com)
Review

done

done
ID primitive.ObjectID `bson:"_id" json:"_id"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
DeviceID string `bson:"deviceID" json:"deviceId"` // unique
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
IP string `bson:"ip" json:"ip"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
OSName string `bson:"osName" json:"osName"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
OSVersion string `bson:"osVersion" json:"osVersion"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
AppVersion string `bson:"appVersion" json:"appVersion"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
Language string `bson:"language" json:"language"` // vi, en
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
IsMobile bool `bson:"isMobile" json:"isMobile"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
LastActivityAt time.Time `bson:"lastActivityAt" json:"lastActivityAt"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
UserID primitive.ObjectID `bson:"userID" json:"userId"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
AuthToken string `bson:"authToken" json:"authToken"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
FCMToken string `bson:"fcmToken" json:"fcmToken"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
CreatedAt time.Time `bson:"createdAt" json:"createdAt"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
ID primitive.ObjectID `bson:"_id" json:"_id"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
DeviceID string `bson:"deviceID" json:"deviceId"` // unique
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
IP string `bson:"ip" json:"ip"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
OSName string `bson:"osName" json:"osName"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
OSVersion string `bson:"osVersion" json:"osVersion"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
AppVersion string `bson:"appVersion" json:"appVersion"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
Language string `bson:"language" json:"language"` // vi, en
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
IsMobile bool `bson:"isMobile" json:"isMobile"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
LastActivatedAt time.Time `bson:"lastActivatedAt" json:"lastActivatedAt"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
UserID primitive.ObjectID `bson:"userID" json:"userId"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
AuthToken string `bson:"authToken" json:"authToken"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
FCMToken string `bson:"fcmToken" json:"fcmToken"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
CreatedAt time.Time `bson:"createdAt" json:"createdAt"`
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
}

namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
namhq1989 commented 2021-11-05 09:00:31 +00:00 (Migrated from github.com)
Review

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 09:12:09 +00:00 (Migrated from github.com)
Review

done

done
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
namhq1989 commented 2021-11-05 09:17:35 +00:00 (Migrated from github.com)
Review

LastActivatedAt

LastActivatedAt
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done
lqhoang99 commented 2021-11-05 09:25:07 +00:00 (Migrated from github.com)
Review

done

done