Selly-Modules
/
devicemngmt
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add createMethod #2

Merged
lqhoang99 merged 4 commits from feature/createMethod into master 2021-11-05 09:28:06 +00:00
Conversation 0 Commits 4 Files Changed 10 +539
lqhoang99 commented 2021-11-05 07:22:46 +00:00 (Migrated from github.com)
Copy Link
No description provided.
namhq1989 (Migrated from github.com) reviewed 2021-11-05 07:42:34 +00:00
namhq1989 (Migrated from github.com) left a comment
Copy Link
  • module này không có quản lý việc generate token, nó nằm ở module UserManagement
  • auth token là do client truyền vào, module này chỉ save và get, không có nhiệm vụ check nó
  • thêm 1 file validate.go để viết các hàm validate
- module này không có quản lý việc generate token, nó nằm ở module UserManagement - auth token là do client truyền vào, module này chỉ save và get, không có nhiệm vụ check nó - thêm 1 file validate.go để viết các hàm validate
action_create.go
namhq1989 (Migrated from github.com) commented 2021-11-05 07:27:44 +00:00
Copy Link

DeviceCreate -> CreateOptions

DeviceCreate -> CreateOptions
namhq1989 (Migrated from github.com) commented 2021-11-05 07:31:39 +00:00
Copy Link

deviceID already exists -> this device is already existed

deviceID already exists -> this device is already existed
namhq1989 (Migrated from github.com) commented 2021-11-05 07:33:20 +00:00
Copy Link
return fmt.Errorf("error when create device: %s", err.Error())
```go return fmt.Errorf("error when create device: %s", err.Error()) ```
namhq1989 (Migrated from github.com) commented 2021-11-05 07:35:14 +00:00
Copy Link

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 (Migrated from github.com) commented 2021-11-05 07:35:31 +00:00
Copy Link

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 (Migrated from github.com) commented 2021-11-05 07:35:53 +00:00
Copy Link

move ra 1 func khác để validate

move ra 1 func khác để validate
namhq1989 (Migrated from github.com) commented 2021-11-05 07:36:56 +00:00
Copy Link

move ra 1 func khác để set, set cứng device.Language = langVi

move ra 1 func khác để set, set cứng `device.Language = langVi`
namhq1989 (Migrated from github.com) commented 2021-11-05 07:37:25 +00:00
Copy Link

ko cần check userID là mongo id, ko empty là được

ko cần check userID là mongo id, ko empty là được
namhq1989 (Migrated from github.com) commented 2021-11-05 07:37:32 +00:00
Copy Link

bỏ cái này

bỏ cái này
action_create.go
@ -0,0 +18,4 @@
IP string
FCMToken string
AuthToken string
Language string
namhq1989 (Migrated from github.com) commented 2021-11-05 07:30:27 +00:00
Copy Link

thiếu AuthToken

thiếu AuthToken
action_create.go
@ -0,0 +74,4 @@
}
// App version
if payload.AppVersion != "" {
namhq1989 (Migrated from github.com) commented 2021-11-05 07:36:05 +00:00
Copy Link

move ra 1 func khác để set

move ra 1 func khác để set
auth_token.go
namhq1989 (Migrated from github.com) commented 2021-11-05 07:30:02 +00:00
Copy Link

device làm gì có generate token hè? generate token nằm ở bên User Management chớ

device làm gì có generate token hè? generate token nằm ở bên User Management chớ
constant.go
namhq1989 (Migrated from github.com) commented 2021-11-05 07:37:49 +00:00
Copy Link

ko public cái này

ko public cái này
namhq1989 (Migrated from github.com) commented 2021-11-05 07:38:14 +00:00
Copy Link
langVi = "vi"
langEn = "en"
```go langVi = "vi" langEn = "en" ```
devicemngt.go
namhq1989 (Migrated from github.com) commented 2021-11-05 07:38:42 +00:00
Copy Link

bỏ cái này

bỏ cái này
namhq1989 (Migrated from github.com) commented 2021-11-05 07:39:37 +00:00
Copy Link

return thêm Service về nữa

func Init(config Config) (*Service, error) {
  // ...
  return s, nil
}
return thêm Service về nữa ```go func Init(config Config) (*Service, error) { // ... return s, nil } ```
model.go
@ -0,0 +7,4 @@
)
// Device ...
type Device struct {
namhq1989 (Migrated from github.com) commented 2021-11-05 07:41:01 +00:00
Copy Link

define thêm json vào metadata

define thêm `json` vào metadata
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 08:32:48 +00:00
action_create.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 08:32:48 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 08:32:54 +00:00
auth_token.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 08:32:54 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 08:32:59 +00:00
action_create.go
@ -0,0 +18,4 @@
IP string
FCMToken string
AuthToken string
Language string
lqhoang99 (Migrated from github.com) commented 2021-11-05 08:32:59 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 08:33:15 +00:00
action_create.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 08:33:15 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 08:33:21 +00:00
action_create.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 08:33:21 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 08:33:28 +00:00
action_create.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 08:33:28 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 08:33:54 +00:00
action_create.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 08:33:54 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 08:34:00 +00:00
action_create.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 08:34:00 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 08:34:07 +00:00
action_create.go
@ -0,0 +74,4 @@
}
// App version
if payload.AppVersion != "" {
lqhoang99 (Migrated from github.com) commented 2021-11-05 08:34:07 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 08:34:13 +00:00
action_create.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 08:34:13 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 08:34:23 +00:00
action_create.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 08:34:23 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 08:34:30 +00:00
action_create.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 08:34:30 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 08:34:37 +00:00
constant.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 08:34:37 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 08:34:45 +00:00
constant.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 08:34:45 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 08:34:50 +00:00
devicemngt.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 08:34:50 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 08:34:59 +00:00
devicemngt.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 08:34:59 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 08:40:21 +00:00
model.go
@ -0,0 +7,4 @@
)
// Device ...
type Device struct {
lqhoang99 (Migrated from github.com) commented 2021-11-05 08:40:21 +00:00
Copy Link

done

done
namhq1989 (Migrated from github.com) reviewed 2021-11-05 08:58:39 +00:00
action_create.go
namhq1989 (Migrated from github.com) commented 2021-11-05 08:58:38 +00:00
Copy Link

đoạn này + đoạn device id iszero, viết thành 1 func khác isDeviceIDExisted trả về boolean

đoạn này + đoạn device id iszero, viết thành 1 func khác `isDeviceIDExisted` trả về boolean
namhq1989 (Migrated from github.com) reviewed 2021-11-05 09:00:31 +00:00
model.go
namhq1989 (Migrated from github.com) commented 2021-11-05 09:00:31 +00:00
Copy Link

deviceId, json dùng camel case, sửa luôn các id khác

deviceId, json dùng camel case, sửa luôn các id khác
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 09:12:09 +00:00
model.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 09:12:09 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 09:12:15 +00:00
action_create.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 09:12:15 +00:00
Copy Link

done

done
namhq1989 (Migrated from github.com) reviewed 2021-11-05 09:15:35 +00:00
helper.go
@ -0,0 +25,4 @@
logger.Error("devicemngt - findByDeviceID", logger.LogData{
"deviceID": deviceID,
"err": err.Error(),
})
namhq1989 (Migrated from github.com) commented 2021-11-05 09:15:34 +00:00
Copy Link

chỗ này return luôn chớ?

chỗ này return luôn chớ?
namhq1989 (Migrated from github.com) reviewed 2021-11-05 09:17:08 +00:00
helper.go
namhq1989 (Migrated from github.com) commented 2021-11-05 09:17:08 +00:00
Copy Link

gom code khúc này thành return !device.ID.IsZero()

func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false

gom code khúc này thành `return !device.ID.IsZero()` func này check device có tồn tại ko, nên nếu tồn tại trả true, ko tồn tại trả false
namhq1989 (Migrated from github.com) reviewed 2021-11-05 09:17:35 +00:00
model.go
namhq1989 (Migrated from github.com) commented 2021-11-05 09:17:35 +00:00
Copy Link

LastActivatedAt

LastActivatedAt
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 09:25:07 +00:00
model.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 09:25:07 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 09:25:12 +00:00
helper.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 09:25:11 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 09:25:18 +00:00
helper.go
@ -0,0 +25,4 @@
logger.Error("devicemngt - findByDeviceID", logger.LogData{
"deviceID": deviceID,
"err": err.Error(),
})
lqhoang99 (Migrated from github.com) commented 2021-11-05 09:25:18 +00:00
Copy Link

done

done
namhq1989 (Migrated from github.com) approved these changes 2021-11-05 09:27:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
namhq1989
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Selly-Modules/devicemngmt#2
No description provided.
Delete Branch "feature/createMethod"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?