From 2e747ff26bd4c136401edf3573ee99bd1958cbfb Mon Sep 17 00:00:00 2001 From: Nam Huynh Date: Mon, 5 Dec 2022 15:14:06 +0700 Subject: [PATCH] return redis instance in function Connect --- del_key.go | 6 +++--- del_with_prefix.go | 6 +++--- get_by_key.go | 8 ++++---- get_with_prefix_pattern.go | 6 +++--- go.mod | 7 +------ go.sum | 25 ------------------------ mutex.go | 39 -------------------------------------- redisdb.go | 17 +++++++++++------ set_key_value.go | 4 ++-- utils.go | 7 +++++++ 10 files changed, 34 insertions(+), 91 deletions(-) delete mode 100644 mutex.go create mode 100644 utils.go diff --git a/del_key.go b/del_key.go index 78cf946..d9d7127 100644 --- a/del_key.go +++ b/del_key.go @@ -3,6 +3,6 @@ package redisdb import "context" // DelKey ... -func DelKey(ctx context.Context, key string) { - rdb.Del(ctx, key) -} \ No newline at end of file +func (s Server) DelKey(ctx context.Context, key string) { + s.rdb.Del(ctx, key) +} diff --git a/del_with_prefix.go b/del_with_prefix.go index 0656e5a..818dae8 100644 --- a/del_with_prefix.go +++ b/del_with_prefix.go @@ -6,10 +6,10 @@ import ( ) // DelWithPrefix ... -func DelWithPrefix(ctx context.Context, prefix string) { - iter := rdb.Scan(ctx, 0, prefix, 0).Iterator() +func (s Server) DelWithPrefix(ctx context.Context, prefix string) { + iter := s.rdb.Scan(ctx, 0, prefix, 0).Iterator() for iter.Next(ctx) { - err := rdb.Del(ctx, iter.Val()).Err() + err := s.rdb.Del(ctx, iter.Val()).Err() if err != nil { fmt.Println("[redisdb] cannot delete redis key with prefix", prefix) } diff --git a/get_by_key.go b/get_by_key.go index 9e50613..b4cda39 100644 --- a/get_by_key.go +++ b/get_by_key.go @@ -6,8 +6,8 @@ import ( ) // GetValueByKey ... -func GetValueByKey(ctx context.Context, key string) string { - cmd := rdb.Get(ctx, key) +func (s Server) GetValueByKey(ctx context.Context, key string) string { + cmd := s.rdb.Get(ctx, key) if cmd == nil { return "" } @@ -16,8 +16,8 @@ func GetValueByKey(ctx context.Context, key string) string { } // GetJSON ... -func GetJSON(ctx context.Context, key string, result interface{}) (ok bool) { - v := GetValueByKey(ctx, key) +func (s Server) GetJSON(ctx context.Context, key string, result interface{}) (ok bool) { + v := s.GetValueByKey(ctx, key) if v == "" { return false } diff --git a/get_with_prefix_pattern.go b/get_with_prefix_pattern.go index a5addab..e07c09a 100644 --- a/get_with_prefix_pattern.go +++ b/get_with_prefix_pattern.go @@ -5,7 +5,7 @@ import ( ) // GetWithPrefixPattern ... -func GetWithPrefixPattern(pattern string) (keys []string, values []string) { +func (s Server) GetWithPrefixPattern(pattern string) (keys []string, values []string) { // Init keys = make([]string, 0) values = make([]string, 0) @@ -16,7 +16,7 @@ func GetWithPrefixPattern(pattern string) (keys []string, values []string) { err error ) - keys, cursor, err = rdb.Scan(ctx, cursor, pattern, 1000000).Result() + keys, cursor, err = s.rdb.Scan(ctx, cursor, pattern, 1000000).Result() if err != nil { return } @@ -27,7 +27,7 @@ func GetWithPrefixPattern(pattern string) (keys []string, values []string) { // Get value for _, key := range keys { - value := GetValueByKey(ctx, key) + value := s.GetValueByKey(ctx, key) values = append(values, value) } diff --git a/go.mod b/go.mod index 1de0e65..fd5d93f 100644 --- a/go.mod +++ b/go.mod @@ -2,16 +2,11 @@ module git.selly.red/Selly-Modules/redisdb/v3 go 1.19 -require ( - github.com/go-redis/redis/v8 v8.11.4 - github.com/go-redsync/redsync/v4 v4.5.0 -) +require github.com/go-redis/redis/v8 v8.11.4 require ( github.com/cespare/xxhash/v2 v2.1.2 // indirect github.com/dgryski/go-rendezvous v0.0.0-20200823014737-9f7001d12a5f // indirect - github.com/hashicorp/errwrap v1.0.0 // indirect - github.com/hashicorp/go-multierror v1.1.0 // indirect golang.org/x/net v0.1.0 // indirect golang.org/x/sys v0.1.0 // indirect ) diff --git a/go.sum b/go.sum index 3e5043e..ddebb36 100644 --- a/go.sum +++ b/go.sum @@ -7,17 +7,10 @@ github.com/dgryski/go-rendezvous v0.0.0-20200823014737-9f7001d12a5f/go.mod h1:cu github.com/fsnotify/fsnotify v1.4.7/go.mod h1:jwhsz4b93w/PPRr/qN1Yymfu8t87LnFCMoQvtojpjFo= github.com/fsnotify/fsnotify v1.4.9 h1:hsms1Qyu0jgnwNXIxa+/V/PDsU6CfLf6CNO8H7IWoS4= github.com/fsnotify/fsnotify v1.4.9/go.mod h1:znqG4EE+3YCdAaPaxE2ZRY/06pZUdp0tY4IgpuI1SZQ= -github.com/go-redis/redis v6.15.9+incompatible h1:K0pv1D7EQUjfyoMql+r/jZqCLizCGKFlFgcHWWmHQjg= -github.com/go-redis/redis v6.15.9+incompatible/go.mod h1:NAIEuMOZ/fxfXJIrKDQDz8wamY7mA7PouImQ2Jvg6kA= -github.com/go-redis/redis/v7 v7.4.0 h1:7obg6wUoj05T0EpY0o8B59S9w5yeMWql7sw2kwNW1x4= -github.com/go-redis/redis/v7 v7.4.0/go.mod h1:JDNMw23GTyLNC4GZu9njt15ctBQVn7xjRfnwdHj/Dcg= github.com/go-redis/redis/v8 v8.11.4 h1:kHoYkfZP6+pe04aFTnhDH6GDROa5yJdHJVNxV3F46Tg= github.com/go-redis/redis/v8 v8.11.4/go.mod h1:2Z2wHZXdQpCDXEGzqMockDpNyYvi2l4Pxt6RJr792+w= -github.com/go-redsync/redsync/v4 v4.5.0 h1:kJjDzn/iEbU+K/6w+O8b1rzuYIK/nP9EQRc5nXKW9x4= -github.com/go-redsync/redsync/v4 v4.5.0/go.mod h1:AfhgO1E6W3rlUTs6Zmz/B6qBZJFasV30lwo7nlizdDs= github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0/go.mod h1:fyg7847qk6SyHyPtNmDHnmrv/HOrqktSC+C9fM+CJOE= github.com/golang/protobuf v1.2.0/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U= -github.com/golang/protobuf v1.3.2/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U= github.com/golang/protobuf v1.4.0-rc.1/go.mod h1:ceaxUfeHdC40wWswd/P6IGgMaK3YpKi5j83Wpe3EHw8= github.com/golang/protobuf v1.4.0-rc.1.0.20200221234624-67d41d38c208/go.mod h1:xKAWHe0F5eneWXFV3EuXVDTCmh+JuBKY0li0aMyXATA= github.com/golang/protobuf v1.4.0-rc.2/go.mod h1:LlEzMj4AhA7rCAGe4KMBDvJI+AwstrUpVNzEA03Pprs= @@ -26,30 +19,19 @@ github.com/golang/protobuf v1.4.0/go.mod h1:jodUvKwWbYaEsadDk5Fwe5c77LiNKVO9IDvq github.com/golang/protobuf v1.4.2/go.mod h1:oDoupMAO8OvCJWAcko0GGGIgR6R6ocIYbsSw735rRwI= github.com/golang/protobuf v1.5.0/go.mod h1:FsONVRAS9T7sI+LIUmWTfcYkHO4aIWwzhcaSAoJOfIk= github.com/golang/protobuf v1.5.2/go.mod h1:XVQd3VNwM+JqD3oG2Ue2ip4fOMUkwXdXDdiuN0vRsmY= -github.com/gomodule/redigo v1.8.2 h1:H5XSIre1MB5NbPYFp+i1NBbb5qN1W8Y8YAQoAYbkm8k= -github.com/gomodule/redigo v1.8.2/go.mod h1:P9dn9mFrCBvWhGE1wpxx6fgq7BAeLBk+UUUzlpkBYO0= github.com/google/go-cmp v0.3.0/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU= github.com/google/go-cmp v0.3.1/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMywk6iLU= github.com/google/go-cmp v0.4.0/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE= github.com/google/go-cmp v0.5.5/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE= github.com/google/go-cmp v0.5.6/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE= -github.com/hashicorp/errwrap v1.0.0 h1:hLrqtEDnRye3+sgx6z4qVLNuviH3MR5aQ0ykNJa/UYA= -github.com/hashicorp/errwrap v1.0.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4= -github.com/hashicorp/go-multierror v1.1.0 h1:B9UzwGQJehnUY1yNrnwREHc3fGbC2xefo8g4TbElacI= -github.com/hashicorp/go-multierror v1.1.0/go.mod h1:spPvp8C1qA32ftKqdAHm4hHTbPw+vmowP0z+KUhOZdA= github.com/hpcloud/tail v1.0.0/go.mod h1:ab1qPbhIpdTxEkNHXyeSf5vhxWSCs/tWer42PpOxQnU= -github.com/kr/pretty v0.1.0/go.mod h1:dAy3ld7l9f0ibDNOQOHHMYYIIbhfbHSm3C4ZsoJORNo= -github.com/kr/pty v1.1.1/go.mod h1:pFQYn66WHrOpPYNljwOMqo10TkYh1fy3cYio2l3bCsQ= -github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI= github.com/nxadm/tail v1.4.4/go.mod h1:kenIhsEOeOJmVchQTgglprH7qJGnHDVpk1VPCcaMI8A= github.com/nxadm/tail v1.4.8 h1:nPr65rt6Y5JFSKQO7qToXr7pePgD6Gwiw05lkbyAQTE= github.com/nxadm/tail v1.4.8/go.mod h1:+ncqLTQzXmGhMZNUePPaPqPvBxHAIsmXswZKocGu+AU= github.com/onsi/ginkgo v1.6.0/go.mod h1:lLunBs/Ym6LB5Z9jYTR76FiuTmxDTDusOGeTQH+WWjE= -github.com/onsi/ginkgo v1.10.1/go.mod h1:lLunBs/Ym6LB5Z9jYTR76FiuTmxDTDusOGeTQH+WWjE= github.com/onsi/ginkgo v1.12.1/go.mod h1:zj2OWP4+oCPe1qIXoGWkgMRwljMUYCdkwsT2108oapk= github.com/onsi/ginkgo v1.16.4 h1:29JGrr5oVBm5ulCWet69zQkzWipVXIol6ygQUe/EzNc= github.com/onsi/ginkgo v1.16.4/go.mod h1:dX+/inL/fNMqNlz0e9LfyB9TswhZpCVdJM/Z6Vvnwo0= -github.com/onsi/gomega v1.7.0/go.mod h1:ex+gbHU/CVuBBDIJjb2X0qEXbFg53c61hWP/1CpauHY= github.com/onsi/gomega v1.7.1/go.mod h1:XdKZgCCFLUoM/7CFJVPcG8C1xQ1AJ0vpAezJrB7JYyY= github.com/onsi/gomega v1.10.1/go.mod h1:iN09h71vgCQne3DLsj+A5owkum+a2tYe+TOCB1ybHNo= github.com/onsi/gomega v1.16.0 h1:6gjqkI8iiRHMvdccRJM8rVKjCWk6ZIm6FTm3ddIe4/c= @@ -57,8 +39,6 @@ github.com/onsi/gomega v1.16.0/go.mod h1:HnhC7FXeEQY45zxNK3PPoIUhzk/80Xly9PcubAl github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME= github.com/stretchr/testify v1.5.1/go.mod h1:5W2xD1RspED5o8YsWQXVCued0rvSQ+mT+I5cxcmMvtA= -github.com/stvp/tempredis v0.0.0-20181119212430-b82af8480203 h1:QVqDTf3h2WHt08YuiTGPZLls0Wq99X9bWd0Q5ZSBesM= -github.com/stvp/tempredis v0.0.0-20181119212430-b82af8480203/go.mod h1:oqN97ltKNihBbwlX8dLpwxCl3+HnXKV/R0e+sRLd9C8= github.com/yuin/goldmark v1.2.1/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74= golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w= golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI= @@ -67,7 +47,6 @@ golang.org/x/mod v0.3.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA= golang.org/x/net v0.0.0-20180906233101-161cd47e91fd/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4= golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg= golang.org/x/net v0.0.0-20190620200207-3b0461eec859/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s= -golang.org/x/net v0.0.0-20190923162816-aa69164e4478/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s= golang.org/x/net v0.0.0-20200520004742-59133d7f0dd7/go.mod h1:qpuaurCH72eLCgpAm/N6yyVIVM9cpaDIP3A8BGJEC5A= golang.org/x/net v0.0.0-20201021035429-f5854403a974/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU= golang.org/x/net v0.0.0-20210428140749-89ef3d95e781/go.mod h1:OJAsFXCWl8Ukc7SiCT/9KSuxbyM7479/AVlXFRxuMCk= @@ -81,7 +60,6 @@ golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5h golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190904154756-749cb33beabd/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20191005200804-aed5e4c7ecf9/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= -golang.org/x/sys v0.0.0-20191010194322-b09406accb47/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20191120155948-bd437916bb0e/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20200323222414-85ca7c5b95cd/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20200930185726-fdedc70b468f/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= @@ -92,7 +70,6 @@ golang.org/x/sys v0.1.0 h1:kunALQeHf1/185U1i0GOB/fy1IPRDDpuoOOqRReG57U= golang.org/x/sys v0.1.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= -golang.org/x/text v0.3.2/go.mod h1:bEr9sfX3Q8Zfm5fL9x+3itogRgK3+ptLWKqgva+5dAk= golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ= golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ= golang.org/x/text v0.4.0 h1:BrVqGRd7+k1DiOgtnFvAkoQEWQvBc25ouMJM6429SFg= @@ -112,11 +89,9 @@ google.golang.org/protobuf v1.23.0/go.mod h1:EGpADcykh3NcUnDUJcl1+ZksZNG86OlYog2 google.golang.org/protobuf v1.26.0-rc.1/go.mod h1:jlhhOSvTdKEhbULTjvd4ARK9grFBp09yW+WbY/TyQbw= google.golang.org/protobuf v1.26.0/go.mod h1:9q0QmTI4eRPtz6boOQmLYwt+qCgq0jsYwAQnmE0givc= gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= -gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= gopkg.in/fsnotify.v1 v1.4.7/go.mod h1:Tz8NjZHkW78fSQdbUxIjBTcgA1z1m8ZHf0WmKUhAMys= gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 h1:uRGJdciOHaEIrze2W8Q3AKkepLTh2hOroT7a+7czfdQ= gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7/go.mod h1:dt/ZhP58zS4L8KSrWDmTeBkI65Dw0HsyUHuEVlX15mw= -gopkg.in/yaml.v2 v2.2.1/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI= gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI= gopkg.in/yaml.v2 v2.2.4/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI= gopkg.in/yaml.v2 v2.3.0/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI= diff --git a/mutex.go b/mutex.go deleted file mode 100644 index 49a2c4b..0000000 --- a/mutex.go +++ /dev/null @@ -1,39 +0,0 @@ -package redisdb - -import ( - "time" - - "github.com/go-redsync/redsync/v4" - "github.com/go-redsync/redsync/v4/redis/goredis/v8" -) - -// NewMutex ... -func NewMutex(name string) *Mutex { - pool := goredis.NewPool(rdb) - - rs := redsync.New(pool) - - opts := []redsync.Option{ - redsync.WithRetryDelay(time.Millisecond * 100), // retry after 100 ms - redsync.WithTries(10), // try 10 times - } - - m := rs.NewMutex(name, opts...) - - return &Mutex{mu: m} -} - -// Mutex ... -type Mutex struct { - mu *redsync.Mutex -} - -// Lock ... -func (m Mutex) Lock() error { - return m.mu.Lock() -} - -// Unlock ... -func (m Mutex) Unlock() (bool, error) { - return m.mu.Unlock() -} diff --git a/redisdb.go b/redisdb.go index 9b27188..84510ba 100644 --- a/redisdb.go +++ b/redisdb.go @@ -7,15 +7,17 @@ import ( "github.com/go-redis/redis/v8" ) -var ( +type Server struct { rdb *redis.Client -) +} + +var r *Server // Connect ... -func Connect(uri, password string) error { +func Connect(uri, password, server string) (*Server, error) { ctx := context.Background() - rdb = redis.NewClient(&redis.Options{ + rdb := redis.NewClient(&redis.Options{ Addr: uri, Password: password, DB: 0, // use default DB @@ -25,10 +27,13 @@ func Connect(uri, password string) error { _, err := rdb.Ping(ctx).Result() if err != nil { fmt.Printf("[redisdb] connect to %s error: %s \n", uri, err.Error()) - return err + return nil, err } + // assign data + r = &Server{rdb: rdb} + fmt.Printf("⚡️[natsio]: connected to %s \n", uri) - return nil + return r, nil } diff --git a/set_key_value.go b/set_key_value.go index 4251d99..3102d3b 100644 --- a/set_key_value.go +++ b/set_key_value.go @@ -7,7 +7,7 @@ import ( ) // SetKeyValue ... -func SetKeyValue(ctx context.Context, key string, value interface{}, options ...Options) { +func (s Server) SetKeyValue(ctx context.Context, key string, value interface{}, options ...Options) { b, err := json.Marshal(value) if err != nil { fmt.Printf("[redisdb] SetKeyValue error: %s - data: %s - %v \n", err.Error(), key, value) @@ -20,5 +20,5 @@ func SetKeyValue(ctx context.Context, key string, value interface{}, options ... o.apply(&opts) } - rdb.Set(ctx, key, b, opts.ttl) + s.rdb.Set(ctx, key, b, opts.ttl) } diff --git a/utils.go b/utils.go new file mode 100644 index 0000000..244af80 --- /dev/null +++ b/utils.go @@ -0,0 +1,7 @@ +package redisdb + +import "fmt" + +func GenerateKey(server, service, key string) string { + return fmt.Sprintf("%s:%s:%s", server, service, key) +}