Selly-Modules
/
devicemngmt
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add allMethod #3

Merged
lqhoang99 merged 2 commits from feature/AllMethod into master 2021-11-05 10:28:54 +00:00
Conversation 0 Commits 2 Files Changed 4 +51 -11
lqhoang99 commented 2021-11-05 09:58:01 +00:00 (Migrated from github.com)
Copy Link
No description provided.
namhq1989 (Migrated from github.com) reviewed 2021-11-05 10:11:23 +00:00
action_get_all.go
namhq1989 (Migrated from github.com) commented 2021-11-05 10:11:22 +00:00
Copy Link

dùng 1 model để public ra thôi. Dùng cái Device luôn đi

dùng 1 model để public ra thôi. Dùng cái Device luôn đi
namhq1989 (Migrated from github.com) reviewed 2021-11-05 10:12:09 +00:00
action_get_all.go
namhq1989 (Migrated from github.com) commented 2021-11-05 10:12:09 +00:00
Copy Link

cái user id sao phải đưa qua mongo id, nó chỉ là string thôi mà, đã note ở PR cũ rồi

cái user id sao phải đưa qua mongo id, nó chỉ là string thôi mà, đã note ở PR cũ rồi
namhq1989 (Migrated from github.com) reviewed 2021-11-05 10:12:42 +00:00
model.go
@ -17,8 +17,10 @@ type Device struct {
Language string `bson:"language" json:"language"` // vi, en
IsMobile bool `bson:"isMobile" json:"isMobile"`
LastActivatedAt time.Time `bson:"lastActivatedAt" json:"lastActivatedAt"`
namhq1989 (Migrated from github.com) commented 2021-11-05 10:12:42 +00:00
Copy Link

không cần omitempty, default bằng empty string là được rồi

không cần omitempty, default bằng empty string là được rồi
namhq1989 (Migrated from github.com) reviewed 2021-11-05 10:12:58 +00:00
model.go
@ -17,8 +17,10 @@ type Device struct {
Language string `bson:"language" json:"language"` // vi, en
IsMobile bool `bson:"isMobile" json:"isMobile"`
LastActivatedAt time.Time `bson:"lastActivatedAt" json:"lastActivatedAt"`
namhq1989 (Migrated from github.com) commented 2021-11-05 10:12:58 +00:00
Copy Link

bỏ cái này đi, dùng cái Device

bỏ cái này đi, dùng cái Device
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 10:24:19 +00:00
action_get_all.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 10:24:19 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 10:24:26 +00:00
action_get_all.go
lqhoang99 (Migrated from github.com) commented 2021-11-05 10:24:26 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 10:24:34 +00:00
model.go
@ -17,8 +17,10 @@ type Device struct {
Language string `bson:"language" json:"language"` // vi, en
IsMobile bool `bson:"isMobile" json:"isMobile"`
LastActivatedAt time.Time `bson:"lastActivatedAt" json:"lastActivatedAt"`
lqhoang99 (Migrated from github.com) commented 2021-11-05 10:24:34 +00:00
Copy Link

done

done
lqhoang99 (Migrated from github.com) reviewed 2021-11-05 10:24:40 +00:00
model.go
@ -17,8 +17,10 @@ type Device struct {
Language string `bson:"language" json:"language"` // vi, en
IsMobile bool `bson:"isMobile" json:"isMobile"`
LastActivatedAt time.Time `bson:"lastActivatedAt" json:"lastActivatedAt"`
lqhoang99 (Migrated from github.com) commented 2021-11-05 10:24:40 +00:00
Copy Link

done

done
namhq1989 (Migrated from github.com) approved these changes 2021-11-05 10:28:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
namhq1989
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Selly-Modules/devicemngmt#3
No description provided.
Delete Branch "feature/AllMethod"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?